use protoc with presence #108
Conversation
c-cube
force-pushed
the
simon/protoc-with-presence-2025-10-30
branch
2 times, most recently
from
9ea91c4 to
7ab0b0c
Compare
c-cube
force-pushed
the
simon/protoc-with-presence-2025-10-30
branch
from
1f823d4 to
f1ac22e
Compare
.github/workflows/main.yml
Outdated
| - run: | | ||
| opam pin ocaml-protoc 3.0.1 -y -n | ||
| opam pin pbrt 3.0.1 -y -n | ||
| opam pin https://github.com/mransan/ocaml-protoc.git#5510694deffde13283742b8ad116fab61b65dfbc -y -n |
There was a problem hiding this comment.
fyi a nice way to do this even for testing is using a pin-depends field in an *.opam.template file:
https://github.com/semgrep/semgrep/blob/develop/semgrep.opam.template#L17-L20
this gets picked up picked up by dune when it generates the opam file. Additionally, this will also get picked up by nix so you don't have to make the change to flake.nix you have
There was a problem hiding this comment.
Note that currently this opam package fails to install w/out this change
There was a problem hiding this comment.
Now that ocaml-protoc 4.0 is released, pinning 4.0 should also work!
|
Finally getting around to trying this in semgrep, will report back in a week or so. |
|
Hello! We ran this in an experiment framework on ~15k semgrep scans and everything seems to work well on our end. We're excited to see this merged |
c-cube
force-pushed
the
simon/protoc-with-presence-2025-10-30
branch
from
b4257b9 to
3182064
Compare
This should be more compact on the wire, because presence tracking lets us know which fields were not set explicitly so we can avoid writing them entirely. It's also more compliant with other implementations of protobuf.